Add authentication / authorization support to the SDK#4
Merged
Conversation
IMax153
commented
Dec 20, 2025
|
|
||
| readonly requestDeviceAuthorization: (codeChallenge: CodeChallenge) => Effect.Effect< | ||
| DeviceAuthorizationResponse, | ||
| HttpClientError.HttpClientError | TimeoutException | ParseResult.ParseError |
Collaborator
Author
There was a problem hiding this comment.
One big TODO item is to create a more descriptive and targeted error domain for each of these services, but for now while we're developing heavily I'm just propagating all errors through.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for authentication to the Amp TypeScript SDK.
To propagate authentication information along with each request, we leverage a feature of Connect called Context Keys, which are not too dissimilar from
Context/Tagin Effect.An example program that uses the
ArrowFlightservice to send a query might look like the following:One improvement for the future would be to further abstract the way that authentication tokens are propagated through with each request. At the moment, they are always propagated from the filesystem cache, but we could create an abstraction on top that allows the authentication information to come from anywhere.